Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[209] Simplify multiple views by sharing common code in their router #217

Merged
merged 4 commits into from
Jul 25, 2023
Merged

[209] Simplify multiple views by sharing common code in their router #217

merged 4 commits into from
Jul 25, 2023

Conversation

sbegaudeau
Copy link
Contributor

Bug: #209
Signed-off-by: Stéphane Bégaudeau [email protected]

@sbegaudeau sbegaudeau self-assigned this Jul 19, 2023
@sbegaudeau sbegaudeau added this to the 2023.8.0 milestone Jul 19, 2023
@sbegaudeau sbegaudeau linked an issue Jul 19, 2023 that may be closed by this pull request
Improve the reusability of some of our components #209
Closed
@sbegaudeau sbegaudeau changed the title [209] Simplify the domains views by sharing common code in the router [209] Simplify multiple views by sharing common code in their router Jul 23, 2023
@sbegaudeau
Copy link
Contributor Author

sbegaudeau commented Jul 23, 2023 •
edited
Loading

  • I still have to update the views of the project domain in order to share the same header (breadcrumbs, icons, layout)
  • A shell will have to be created for the workspace too (probably with a change in the URL)
  • A shell could be necessary for the profile router)
  • Improve some types shared between some shells and their context values (useOrganization(), useProject() for example)

@sbegaudeau sbegaudeau merged commit 2c14b24 into main Jul 25, 2023
2 checks passed
@sbegaudeau sbegaudeau deleted the sbe/enh/routes branch July 25, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbegaudeau sbegaudeau

Labels
pr: to review soon
Projects
Svalyn Studio
Status: Done
Milestone
2023.8.0
Development

Successfully merging this pull request may close these issues.

Improve the reusability of some of our components
1 participant
@sbegaudeau